tbouron commented on a change in pull request #1061: Granularity entitlement 
control
URL: https://github.com/apache/brooklyn-server/pull/1061#discussion_r274307210
 
 

 ##########
 File path: 
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ServerResource.java
 ##########
 @@ -118,7 +118,9 @@ public void shutdown(final boolean stopAppsFirst, final 
boolean forceShutdownOnE
         
         if (!Entitlements.isEntitled(mgmt().getEntitlementManager(), 
Entitlements.SEE_ALL_SERVER_INFO, null))
             throw WebResourceUtils.forbidden("User '%s' is not authorized for 
this operation", Entitlements.getEntitlementContext().user());
-        
+        if (!Entitlements.isEntitled(mgmt().getEntitlementManager(), 
Entitlements.SHUTDOWN, null))
+            throw WebResourceUtils.forbidden("User '%s' is not authorized for 
shutdown", Entitlements.getEntitlementContext().user());
 
 Review comment:
   The message should say: `User '%s' is not authorized to shutdown the server`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to