Having completely failed to look into the build issues I can at least try to fit doing some reviewing into my day. Although my go skills are below mediocre so hopefully someone else can look too.
On Tue, 3 Sep 2019 at 02:54, Peter Abramowitsch <pabramowit...@gmail.com> wrote: > Hi Geoff. I gave it a shot, but am not familiar with the go language to be > of any use as a peer reviewer, nor am I familiar with the internals of the > client. > > Sorry. > I feel I owe you one, after your patient help with all my questions. > > ((I'm still fighting with my external secrets supplier.. and bit by bit I > am winning. I could find on how the property Map created for the supplier > in brooklyn.cfg is transformed into the supplier's required (Object ... > args) constructor. The unit test bypasses that mode of injection. Time > for lots of debug statements)) > > Peter > > On Mon, Sep 2, 2019 at 9:16 AM Geoff Macartney <geoff.macart...@gmail.com> > wrote: > > > Hi all, > > > > Any takers to review/approve > > https://github.com/apache/brooklyn-client/pull/78? > > > > Thanks > > Geoff > > > -- Duncan Grant Lead Software Engineer *Cloudsoft <https://cloudsoft.io/> *| Bringing Business to the Cloud GitHub: https://github.com/duncangrant/
