aledsage opened a new pull request #160: URL: https://github.com/apache/brooklyn-dist/pull/160
Accompanies https://github.com/apache/brooklyn-server/pull/1092; that PR must be merged first. Excludes BouncyCastle 1.51 in karaf - using `bundleReplacements` in `org.apache.karaf.features.xml`. --- I confirmed this works by running the karaf client (`./bin/client`), and looking at: ``` karaf@brooklyn()> feature:info jclouds-services Feature jclouds-services 2.1.2 Feature contains followed bundles: ... mvn:org.bouncycastle/bcprov-ext-jdk15on/1.61 (overriden from mvn:org.bouncycastle/bcprov-ext-jdk15on/1.51) ... karaf@brooklyn()> feature:info jclouds-driver-bouncycastle Feature jclouds-driver-bouncycastle 2.1.2 Feature contains followed bundles: ... mvn:org.bouncycastle/bcprov-ext-jdk15on/1.61 (overriden from mvn:org.bouncycastle/bcprov-ext-jdk15on/1.51) mvn:org.bouncycastle/bcpkix-jdk15on/1.61 (overriden from mvn:org.bouncycastle/bcpkix-jdk15on/1.51) mvn:org.apache.jclouds.driver/jclouds-bouncycastle/2.1.2 karaf@brooklyn()> feature:info jclouds-driver-sshj Feature jclouds-driver-sshj 2.1.2 Feature contains followed bundles: ... mvn:net.i2p.crypto/eddsa/0.2.0 (overriden from mvn:net.i2p.crypto/eddsa/0.1.0) mvn:com.hierynomus/sshj/0.22.0 (overriden from mvn:com.hierynomus/sshj/0.20.0) ... ``` Both versions of BouncyCastle are still shipped with Brooklyn in the systems folder: ``` > assembly % find . -name "*bcp*.jar" ./system/org/bouncycastle/bcprov-ext-jdk15on/1.61/bcprov-ext-jdk15on-1.61.jar ./system/org/bouncycastle/bcprov-ext-jdk15on/1.51/bcprov-ext-jdk15on-1.51.jar ./system/org/bouncycastle/bcpkix-jdk15on/1.61/bcpkix-jdk15on-1.61.jar ./system/org/bouncycastle/bcpkix-jdk15on/1.51/bcpkix-jdk15on-1.51.jar ``` However, I think we can live with that. --- I think we could probably get away without this override. The jclouds features use `<bundle dependency=true ...`, see: https://github.com/jclouds/jclouds-karaf/blob/rel/jclouds-karaf-2.1.2-rc1/feature/src/main/feature/feature.xml#L469 The means the bundle doesn't get installed if the dependency is already satisfied, as described at: http://karaf.922171.n3.nabble.com/features-xml-dependency-quot-true-quot-td3286359.html ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
