duncangrant commented on a change in pull request #1090:
URL: https://github.com/apache/brooklyn-server/pull/1090#discussion_r412970334
##########
File path:
locations/container/src/main/java/org/apache/brooklyn/container/location/kubernetes/KubernetesLocation.java
##########
@@ -186,13 +185,36 @@ public KubernetesMachineLocation obtain(Map<?, ?> flags) {
@Override
public void release(KubernetesMachineLocation machine) {
Entity entity = validateCallerContext(machine);
+ reinitClientIfExpired(entity);
Review comment:
I think this is the wrong place for this. There are other places where
we use the client e.g. obtain and undeploy. We would need to call this
function before each use of the client in all these places. I wonder if it
might be better to move this to the getClient function and replace all calls to
the client field with calls to getClient?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
