ahgittin commented on a change in pull request #1100:
URL: https://github.com/apache/brooklyn-server/pull/1100#discussion_r429815813
##########
File path: locations/container/pom.xml
##########
@@ -32,6 +32,32 @@
</parent>
<dependencies>
+ <dependency>
+ <groupId>org.microbean</groupId>
+ <artifactId>microbean-helm</artifactId>
+ <version>2.12.4-SNAPSHOT</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.yaml</groupId>
+ <artifactId>snakeyaml</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>com.google.errorprone</groupId>
+ <artifactId>error_prone_annotations</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-tcnative-boringssl-static</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <!-- Added this dependency explicitly, to calm down IntelliJ IDEA and
also upgrade this -->
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-tcnative-boringssl-static</artifactId>
+ <version>2.0.30.Final</version>
+ <classifier>${os.detected.classifier}</classifier>
Review comment:
This looks questionable -- we need to build cross-platform eg when we
release. I think this breaks that requirement.
ISTR there is an "all platforms" version of the JAR above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
