ahgittin commented on a change in pull request #1115: URL: https://github.com/apache/brooklyn-server/pull/1115#discussion_r504314768
########## File path: core/src/main/java/org/apache/brooklyn/core/typereg/BrooklynCatalogBundleResolver.java ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.brooklyn.core.typereg; + +import com.google.common.annotations.Beta; +import java.io.File; +import java.io.InputStream; +import java.util.ServiceLoader; +import java.util.function.Supplier; +import javax.annotation.Nonnull; +import javax.annotation.Nullable; +import org.apache.brooklyn.api.typereg.BrooklynTypeRegistry; +import org.apache.brooklyn.api.typereg.ManagedBundle; +import org.apache.brooklyn.core.mgmt.ManagementContextInjectable; +import org.apache.brooklyn.core.mgmt.ha.OsgiBundleInstallationResult; +import org.apache.brooklyn.util.exceptions.ReferenceWithError; + +/** + * Interface for use by schemes which provide the capability to add types to the type registry. + * Typically this is by installing an OSGi bundle with metadata, or sometimes with a YAML file. + * <p> + * To add a new resolver for a bundle of types, simply create an implementation and declare it + * as a java service (cf {@link ServiceLoader}). Review comment: indeed, and that tripped me up before. again i copied the comment from `BrooklynTypePlanTransformer` and I've updated both to refer to OSGi services as preferred ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
