ahgittin commented on a change in pull request #1175:
URL: https://github.com/apache/brooklyn-server/pull/1175#discussion_r640834576
##########
File path:
core/src/main/java/org/apache/brooklyn/core/typereg/RegisteredTypes.java
##########
@@ -333,7 +332,20 @@ public static RegisteredType addAliases(RegisteredType
type, Iterable<String> al
@Beta
public static RegisteredType addTag(RegisteredType type, Object tag) {
if (tag!=null) {
- ((BasicRegisteredType)type).tags.add( tag );
+ if (tag instanceof Map &&( (Map<String,Object>)
tag).containsKey(BrooklynTags.YAML_SPEC_HIERARCHY)) {
Review comment:
special-casing this tag here feels wrong. feels like the logic belongs
in `BrooklynTags` or `HierarchySpecTag`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
