algairim commented on a change in pull request #206:
URL: https://github.com/apache/brooklyn-ui/pull/206#discussion_r642535993



##########
File path: ui-modules/blueprint-composer/app/components/dsl-editor/dsl-editor.js
##########
@@ -368,7 +368,7 @@ export function dslEditorDirective($rootScope, $filter, 
$log, brUtilsGeneral, bl
             }
         }
 
-        return new Dsl(KIND.METHOD, 'component').param(new Dsl(KIND.STRING, 
targetEntity.id));
+        return new Dsl(KIND.TARGET, TARGET.COMPONENT).param(new 
Dsl(KIND.STRING, targetEntity.id));

Review comment:
       DSL of kind METHOD referring to COMPONENT target created on select by 
default, however, it did not make sense, I changed this to be kind TARGET. 
@tbouron, could you confirm that this is correct? I did not find a test to 
break with this change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to