iuliana commented on a change in pull request #1257:
URL: https://github.com/apache/brooklyn-server/pull/1257#discussion_r708586171
##########
File path:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogInitialization.java
##########
@@ -241,24 +241,23 @@ public void
populateInitialAndPersistedCatalog(ManagementNodeState mode, Persist
}
synchronized (populatingCatalogMutex) {
if (hasRunFinalInitialization()) {
- log.warn("Catalog initialization called to add persisted
catalog, even though it has already run the final 'master' initialization;
mode="+mode+" (perhaps previously demoted from master?)");
+ log.warn("Catalog initialization called to add persisted
catalog, even though it has already run the final 'master' initialization;
mode="+mode, new Throwable("Source of duplicate catalog initialization"));
hasRunFinalInitialization = false;
}
if (hasRunPersistenceInitialization()) {
// Multiple calls; will need to reset (only way to clear out
the previous persisted state's catalog)
if (log.isDebugEnabled()) {
String message = "Catalog initialization repeated call to
add persisted catalog, resetting catalog (including initial) to start from
clean slate; mode="+mode;
- if (!ManagementNodeState.isHotProxy(mode)) {
- log.debug(message);
- } else {
- // in hot modes, make this message trace so we don't
get too much output then
- log.trace(message);
- }
+ log.debug(message);
Review comment:
Just put the string value here, no need for the message variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
