ahgittin commented on pull request #298: URL: https://github.com/apache/brooklyn-ui/pull/298#issuecomment-949409037
I don't feel strongly about `browserSession` being a util module or using the storage api directly. maybe slight preference for the former (what you've done). but worth a comment that `// some places use browser storage APIs directly; TODO update those to use this` however as noted, module-specific semantics should _not_ be in the `utils`. so maybe API should be `getSession(KEY)` where `KEY` is defined _locally_ in each module/directive not in `utils/.../xxx.KEYS` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
