ahgittin commented on a change in pull request #1266:
URL: https://github.com/apache/brooklyn-server/pull/1266#discussion_r739261295
##########
File path:
core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java
##########
@@ -248,6 +248,7 @@ public String toString() {
boolean hasTypeInheritance =
inputDef.containsKey("inheritance.type");
ConfigInheritance typeInheritance =
parseInheritance(inputDef.get("inheritance.type"), loader);
+ boolean isReconfigurable = inputDef.containsKey("reconfigurable")
&& inputDef.get("reconfigurable").equals(true);
Review comment:
could this fail if reconfigurable is `"true"` -- a string? can we make
this:
```
Boolean isReconfigurable =
TypeCoercions.coerce(inputDef.get("reconfigurable"), Boolean.class);
```
then
```
if (isReconfigurable!=null) builder.reconfigurable(isReconfigurable);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
