algairim commented on code in PR #332:
URL: https://github.com/apache/brooklyn-ui/pull/332#discussion_r893497418
##########
ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js:
##########
@@ -548,7 +548,11 @@ function BlueprintService($log, $q, $sce, paletteApi,
iconGenerator, dslService,
Object.values(entity.getClusterMemberspecEntities()).forEach((memberSpec)=> {
// memberSpec can be `undefined` if the member spec is not a
`$brooklyn:entitySpec`, e.g. it is `$brooklyn:config("spec")`.
// there may be a better way but this seems to handle it.
- if (memberSpec)
promiseArray.push(refreshBlueprintMetadata(memberSpec, 'SPEC'));
+ if (memberSpec instanceof Entity) {
+ // TODO: 'refreshBlueprintMetadata' expects fields of class
Entity.
+ // TODO: Does this route ever happen for 'memberSpec'?
+ promiseArray.push(refreshBlueprintMetadata(memberSpec,
'SPEC'));
+ }
Review Comment:
@ahgittin, I'm not sure what is the right logic supposed to be here. Any
ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
