[GitHub] [brooklyn-server] ahgittin commented on a diff in pull request #1322: fix most reliances on deleteOnExit, deleting when done with the file

[GitBox]

ahgittin commented on code in PR #1322:
URL: https://github.com/apache/brooklyn-server/pull/1322#discussion_r907092562


##########
core/src/main/java/org/apache/brooklyn/core/mgmt/ha/BrooklynBomOsgiArchiveInstaller.java:
##########
@@ -96,8 +96,21 @@ public class BrooklynBomOsgiArchiveInstaller {
     private boolean force = false;
     private boolean deferredStart = false;
     private boolean validateTypes = true;
-    
-    private File zipFile;
+
+    public static class FileWithTempInfo<T extends File> {
+        public FileWithTempInfo(T f, boolean isTemp) { this.f = f; this.isTemp 
= isTemp; }
+        public T f;

Review Comment:
   don't want to make it final because it's nice to set `null` when deleted; 
but agree with accessor, added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org