algairim commented on code in PR #335:
URL: https://github.com/apache/brooklyn-ui/pull/335#discussion_r907193053
##########
ui-modules/utils/quick-launch/quick-launch.js:
##########
@@ -122,13 +122,17 @@ export function quickLaunchDirective() {
if ($scope.app.config) {
$scope.configMap = $scope.app.config.reduce((result, config)
=> {
result[config.name] = config;
- const configValue = parseConfigValue(get(parsedPlan,
`services[0][${BROOKLYN_CONFIG}][${config.name}]`));
+
+ const planConfigValue =
parseConfigValue((parsedPlan[BROOKLYN_CONFIG] || {})[config.name]);
+ const catalogItemConfigValue =
parseConfigValue((parsedPlan.services[0] &&
parsedPlan.services[0][BROOKLYN_CONFIG] || {})[config.name]);
+ const configValue = planConfigValue ||
catalogItemConfigValue;
Review Comment:
@ahgittin, https://github.com/apache/brooklyn-ui/pull/341 addresses
suggested improvements. I am reluctant to change the handling of the default
value as it has extra conditions, and it was not the original issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
