[GitHub] [brooklyn-server] ahgittin commented on a diff in pull request #1280: Use toURI on resource URLs to fix Windows path issues

[GitBox]

ahgittin commented on code in PR #1280:
URL: https://github.com/apache/brooklyn-server/pull/1280#discussion_r907354236


##########
utils/common/src/test/java/org/apache/brooklyn/util/io/FileUtilTest.java:
##########
@@ -123,26 +126,30 @@ public void testIsJavaFileNull(){
     }
 
     @Test
-    public void testIsJavaFileText() throws IOException {
-        byte[] bytes = 
java.nio.file.Files.readAllBytes(Paths.get(this.getClass().getClassLoader().getResource("brooklyn/osgi/brooklyn-osgi-test-a_0.1.0.txt").getPath()));
+    public void testIsJavaFileText() throws IOException, URISyntaxException {
+        byte[] bytes = java.nio.file.Files.readAllBytes(
+               
Paths.get(this.getClass().getClassLoader().getResource("brooklyn/osgi/brooklyn-osgi-test-a_0.1.0.txt").toURI()));
         
assertFalse(FileUtil.doesZipContainJavaBinaries(InputStreamSource.of("Test bom 
file", bytes)));

Review Comment:
   applied in e027d155ec346c4f8bb62b14af892043aa01bfba



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org