[GitHub] [brooklyn-server] iuliana commented on a diff in pull request #1321: Adding Kubectl Task factory, Docker effector and Docker Sensor

[GitBox]

iuliana commented on code in PR #1321:
URL: https://github.com/apache/brooklyn-server/pull/1321#discussion_r907433074


##########
software/base/src/main/java/org/apache/brooklyn/tasks/kubectl/ContainerCommons.java:
##########
@@ -34,6 +38,10 @@ public interface ContainerCommons {
     ConfigKey<List> COMMANDS = ConfigKeys.newConfigKey(List.class,"commands", 
"Commands to execute for container", Lists.newArrayList());
     ConfigKey<List> ARGUMENTS = ConfigKeys.newConfigKey(List.class,"args", 
"Arguments to execute for container", Lists.newArrayList());
 
+    ConfigKey<String> WORKING_DIR = 
ConfigKeys.newStringConfigKey("workingDir", "Location where the container 
commands are executed");
+    ConfigKey<List<Map<String,String>>> VOLUME_MOUNTS = 
ConfigKeys.newConfigKey("volumeMounts", "Configuration to  mount a volume  into 
a container.", Lists.newArrayList());

Review Comment:
   Addressed comments in the most recent commit. @ahgittin 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org