geomacy commented on code in PR #1329:
URL: https://github.com/apache/brooklyn-server/pull/1329#discussion_r910449211
##########
software/base/src/main/java/org/apache/brooklyn/tasks/kubectl/JobBuilder.java:
##########
@@ -121,6 +130,11 @@ public String build(){
containerSpec.setWorkingDir(workingDir);
}
containerSpec.setImage(imageName);
+ if(Strings.isNonBlank(imagePullPolicy)) {
+ if (PULL_POLICY_ALLOWED_VALUES.contains(imagePullPolicy)) {
+ containerSpec.setImagePullPolicy(imagePullPolicy);
+ } // else stick with default, do not fail
Review Comment:
surely it would be better to fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
