algairim commented on code in PR #1333:
URL: https://github.com/apache/brooklyn-server/pull/1333#discussion_r913811376
##########
software/base/src/main/java/org/apache/brooklyn/tasks/kubectl/ContainerTaskFactory.java:
##########
@@ -68,10 +68,8 @@ public Task<RET> newTask() {
final String containerName = (Strings.isBlank(containerNameFromCfg)
? ( (Strings.isNonBlank(this.tag) ? this.tag + "-" :
"").concat(cleanImageName).concat("-").concat(Strings.makeRandomId(10)))
- : containerNameFromCfg).replace(" ", "-")
- .replace("/", "-")
- .replace("_", "-")
- .replaceAll("[^a-z0-9-]", "") // remove other symbols
+ : containerNameFromCfg)
+ .replaceAll("[^A-Za-z0-9-]", "") // remove all symbols
Review Comment:
`kubectl` throws a failure if not comply with the naming conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
