jcabrerizo commented on code in PR #345:
URL: https://github.com/apache/brooklyn-ui/pull/345#discussion_r918117843
##########
ui-modules/app-inspector/app/components/stream/stream.template.html:
##########
@@ -19,10 +19,10 @@
<loading-state error="error" ng-if="stream === undefined"></loading-state>
<div ng-show="stream.length >= 0">
- <pre ng-if="stream.length > 0 && !isFormatContent()"
class="auto-scrollable">{{stream}}</pre>
- <pre ng-if="stream.length > 0 && isFormatContent() && isFilterContent()"
class="auto-scrollable"><pre ng-repeat="item in filteredStream track by
item.id" ng-show="isDisplayFormattedItem(item)" class="log-section"
ng-class="getFormattedItemLogLevel(item)">{{item.text}}</pre><p
ng-show="!isDisplayTrace && !isDisplayDebug && !isDisplayWarning &&
!isDisplayError && !isDisplayOther" class="text-center"><i>(select
filter)</i></p></pre>
- <pre ng-if="stream.length > 0 && isFormatContent() && !isFilterContent()"
class="auto-scrollable">{{formattedStream}}</pre>
- <pre ng-if="stream.length == 0" class="text-center"><i>(no content)</i></pre>
+ <pre ng-show="stream.length > 0 && !isFormatContent()"
class="auto-scrollable">{{stream}}</pre>
+ <pre ng-show="stream.length > 0 && isFormatContent() && isFilterContent()"
class="auto-scrollable"><div ng-if="isFilterContent()"><pre ng-repeat="item in
filteredStream track by item.id" ng-show="isDisplayFormattedItem(item)"
class="log-section"
ng-class="getFormattedItemLogLevel(item)">{{item.text}}</pre><div><p
ng-show="!isDisplayTrace && !isDisplayDebug && !isDisplayWarning &&
!isDisplayError && !isDisplayOther" class="text-center"><i>(select
filter)</i></p></pre>
Review Comment:
Is not the second `<div ng-if="isFilterContent()">` redundant as the
condition is part of the -now- `ng-show`?
##########
ui-modules/app-inspector/app/components/stream/stream.template.html:
##########
@@ -19,10 +19,10 @@
<loading-state error="error" ng-if="stream === undefined"></loading-state>
<div ng-show="stream.length >= 0">
- <pre ng-if="stream.length > 0 && !isFormatContent()"
class="auto-scrollable">{{stream}}</pre>
- <pre ng-if="stream.length > 0 && isFormatContent() && isFilterContent()"
class="auto-scrollable"><pre ng-repeat="item in filteredStream track by
item.id" ng-show="isDisplayFormattedItem(item)" class="log-section"
ng-class="getFormattedItemLogLevel(item)">{{item.text}}</pre><p
ng-show="!isDisplayTrace && !isDisplayDebug && !isDisplayWarning &&
!isDisplayError && !isDisplayOther" class="text-center"><i>(select
filter)</i></p></pre>
- <pre ng-if="stream.length > 0 && isFormatContent() && !isFilterContent()"
class="auto-scrollable">{{formattedStream}}</pre>
- <pre ng-if="stream.length == 0" class="text-center"><i>(no content)</i></pre>
+ <pre ng-show="stream.length > 0 && !isFormatContent()"
class="auto-scrollable">{{stream}}</pre>
+ <pre ng-show="stream.length > 0 && isFormatContent() && isFilterContent()"
class="auto-scrollable"><div ng-if="isFilterContent()"><pre ng-repeat="item in
filteredStream track by item.id" ng-show="isDisplayFormattedItem(item)"
class="log-section"
ng-class="getFormattedItemLogLevel(item)">{{item.text}}</pre><div><p
ng-show="!isDisplayTrace && !isDisplayDebug && !isDisplayWarning &&
!isDisplayError && !isDisplayOther" class="text-center"><i>(select
filter)</i></p></pre>
Review Comment:
ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
