ahgittin commented on PR #1389: URL: https://github.com/apache/brooklyn-server/pull/1389#issuecomment-1519854466
@jcabrerizo this is effective but a few things seem wrong to me: (1) `Sanitizer.suppress` methods are to _replace_ sensitive fields eg password with a hashcode so they are hidden. It feels like the wrong place to put logic for excluding content which is unwanted for other reasons eg optimizing size. (2) `getValueForDisplay` doing a global exclusion of fields anywhere, to hide `output` and `stderr` in workflow and tasks, also feels wrong, and likely to exclude those fields in other places where we might want them. Can this logic live elsewhere so exclusion be more targeted? The `TaskTransformer` feels like it might be the right place for both the above to live. Where Workflow objects are stored as sensors it is trickier, as probably when listing sensors we normally don't usually want a huge amount of data back, but also we don't have the same context as elsewhere. I'm uncomfortable just removing any field named `output`, seems arbitrary. Not sure what to do here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
