Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/131#discussion_r16923776
  
    --- Diff: usage/rest-api/src/main/java/brooklyn/rest/api/EffectorApi.java 
---
    @@ -79,7 +79,8 @@ public Response invoke(
           @QueryParam("timeout")
           String timeout,
           
    -      @ApiParam(name = "parameters", value = "Effector parameters (as key 
value pairs)", required = false)
    +      @ApiParam(/* FIXME: giving a `name` in swagger @ApiParam seems wrong 
as this object is the body, not a named argument */ name = "parameters",
    --- End diff --
    
    '"just" to open a jira issue' ... that takes minutes compared to seconds to 
type this.  and personally i'm more likely to see it if it's here.
    
    agree jira if we need visibility but for small aide-memoires having this 
here is better than not having it here, imho


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to