GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/148
Fix ServiceStateLogicTest
Previously `testManuallySettingIndicatorsOnApplicationsIsMoreComplicated`
failed non-deterministically. Though this test name suggested the failure was
because it wasn't complicated enough, the actual cause was mostly down to using
`assertAttributeEqualsEventually` instead of `assertAttributeEquals` or a
couple of wrong assertions `:-)`.
I added some `assertAttributeEqualsContinually` assertions for when we
expect the state to remain the same after changing some other attribute or
config. This is because the test failed non-deterministically (which could be
made deterministic with some `sleep(1000)` added temporarily.
I renamed the test to `testManuallySettingIndicatorsOnApplications`. Longer
term, it might well be worth splitting this big test into multiple small tests
that each test a smaller number of cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn
fix/ServiceStateLogicTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #148
----
commit eec69f3e44084bb5348ab5950b63a344e58bf895
Author: Aled Sage <[email protected]>
Date: 2014-09-05T15:09:01Z
Add javadoc to QuorumCheck
commit 6e0b31d8bb1cbee14a7ba5173e9850c76760df96
Author: Aled Sage <[email protected]>
Date: 2014-09-05T15:09:16Z
Fix testManuallySettingIndicatorsOnApplications
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
