Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/6#issuecomment-54989293
Thanks for the PR Andrea - sorry that I have had to make quite a few
comments on it. It seems to be performing several different changes - changing
the nav categories, renaming pages, adding content - that should have been
split into different commits. It also seems to be going beyond the scope of
BROOKLYN-55 which was to add details of server installation, so I think that
the changes unrelated to BROOKLYN-55 should have been in a different PR.
Specifically regarding BROOKLYN-55, I don't think that the content changes
have fully addressed the bug report. A server installation is different to a
desktop installation (and the desktop installation should be satisfactorily
described [on the current
site](https://brooklyn.incubator.apache.org/quickstart/index.html)) and that
page needs to cover things like making sure that the install is remotely and
securely accessible, and how to start Brooklyn in such a way that it doesn't
terminate when you log out of the server.
I would suggest that you re-visit the server install page content, and add
it as a child of the "documentation" navigation group.
The other changes you made to the navigation and them home page can
certainly be considered - they are *not* sacred! - but they need to be
justified and I would not merge them until they have been reviewed by at least
two people. Adding content, however, is a much simpler review process, and it
can be reviewed and published to the website in little time, which is why I
strongly recommend that the changes are separated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
