[ 
https://issues.apache.org/jira/browse/BROOKLYN-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127121#comment-14127121
 ] 

ASF GitHub Bot commented on BROOKLYN-55:
----------------------------------------

Github user richardcloudsoft commented on the pull request:

    
https://github.com/apache/incubator-brooklyn-site/pull/6#issuecomment-54989293
  
    Thanks for the PR Andrea - sorry that I have had to make quite a few 
comments on it. It seems to be performing several different changes - changing 
the nav categories, renaming pages, adding content - that should have been 
split into different commits. It also seems to be going beyond the scope of 
BROOKLYN-55 which was to add details of server installation, so I think that 
the changes unrelated to BROOKLYN-55 should have been in a different PR.
    
    Specifically regarding BROOKLYN-55, I don't think that the content changes 
have fully addressed the bug report. A server installation is different to a 
desktop installation (and the desktop installation should be satisfactorily 
described [on the current 
site](https://brooklyn.incubator.apache.org/quickstart/index.html)) and that 
page needs to cover things like making sure that the install is remotely and 
securely accessible, and how to start Brooklyn in such a way that it doesn't 
terminate when you log out of the server.
    
    I would suggest that you re-visit the server install page content, and add 
it as a child of the "documentation" navigation group.
    
    The other changes you made to the navigation and them home page can 
certainly be considered - they are *not* sacred! - but they need to be 
justified and I would not merge them until they have been reviewed by at least 
two people. Adding content, however, is a much simpler review process, and it 
can be reviewed and published to the website in little time, which is why I 
strongly recommend that the changes are separated.


> Documentation for a server install
> ----------------------------------
>
>                 Key: BROOKLYN-55
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-55
>             Project: Brooklyn
>          Issue Type: Sub-task
>    Affects Versions: 0.7.0-M1
>            Reporter: Richard Downer
>            Assignee: Andrea Turli
>             Fix For: 0.7.0
>
>
> Document how to install Brooklyn onto a server (not onto a local workstation) 
> - include typical considerations such as where to install files, remote 
> access, automatic startup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to