Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/158#issuecomment-55187616
Have reviewed second commit that just came through. Not certain if 3
seconds default timeout is too short, but don't have a better number to
suggest. Merging.
@sjcorbett thank for pointer to `LocalhostExternalIpLoader`. The
try-finally looks to be in the wrong place. It sets triedLocalExternalIp inside
the for loop rather than after. Is that right?
https://github.com/apache/incubator-brooklyn/blob/master/core/src/main/java/brooklyn/location/geo/LocalhostExternalIpLoader.java#L139-156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
