Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/161#discussion_r17776820
  
    --- Diff: 
software/base/src/test/java/brooklyn/entity/brooklynnode/BrooklynNodeIntegrationTest.java
 ---
    @@ -427,6 +431,48 @@ public void testHttps() throws Exception {
             }
         }
     
    +    public void testStopAndKillAppsEffector() throws Exception {
    +        
createNodeAndExecStopEffector(BrooklynNode.STOP_NODE_AND_KILL_APPS);
    +    }
    +
    +    public void testStopButLeaveAppsEffector() throws Exception {
    +        
createNodeAndExecStopEffector(BrooklynNode.STOP_NODE_BUT_LEAVE_APPS);
    +    }
    +
    +    private void createNodeAndExecStopEffector(Effector<?> eff) throws 
Exception {
    --- End diff --
    
    The test models the logic in testCanStartAndStop where stopping the app is 
confirmed with SERVICE_UP == false. Nevertheless I am adding a check with 
getDriver().isRunning() (let's see what you think of it).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to