Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/241#discussion_r18886557
  
    --- Diff: 
software/monitoring/src/test/java/brooklyn/entity/monitoring/monit/MonitIntegrationTest.java
 ---
    @@ -49,37 +50,26 @@
     import com.google.common.io.Files;
     
     public class MonitIntegrationTest extends BrooklynAppLiveTestSupport {
    -    
    -    /*
    -     * FIXME Has the monit node output changed? Now it is listing 'cron' 
as well as system.
    -     * It keeps reporting "Does" rather than "Running" as the status.
    -     * Should we be getting the rest of the line after "status" (and 
trimming), rather than
    -     * just the first word?
    -
    -    input=The Monit daemon 5.9 uptime: 0m
    -            Process 'cron'
    -              status                            Does not exist
    -              monitoring status                 Monitored
    -              data collected                    Mon, 13 Oct 2014 21:27:01
    -            System 'aleds-macbook-pro.local'
    -              status                            Running
    -              monitoring status                 Monitored
    -              load average                      [5.16] [4.73] [4.45]
    -              cpu                               7.1%us 5.7%sy
    -              memory usage                      11.6 GB [72.3%]
    -              swap usage                        3.0 GB [74.7%]
    -              data collected                    Mon, 13 Oct 2014 21:27:01
     
    -     */
    -    
         private static final Logger LOG = 
LoggerFactory.getLogger(MonitIntegrationTest.class);
         
         LocalhostMachineProvisioningLocation loc;
    +    Process testProcess;
         
         @BeforeMethod(alwaysRun=true)
         public void setUp() throws Exception {
             super.setUp();
             loc = app.newLocalhostProvisioningLocation();
    +        testProcess = (new ProcessBuilder()).command("vi", 
"monittest").start();
    --- End diff --
    
    Actually, ignore me: this needs to match the contents of `monit.monitrc`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to