Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/243#discussion_r18889507
--- Diff:
software/network/src/main/java/brooklyn/entity/network/bind/BindDnsServerImpl.java
---
@@ -63,7 +63,7 @@
private static final Logger LOG =
LoggerFactory.getLogger(BindDnsServerImpl.class);
private AtomicLong serial = new AtomicLong(System.currentTimeMillis());
- private Object[] mutex = new Object[0];
+ private final Object[] mutex = new Object[0];
--- End diff --
Personal preference: use `new Object()` for mutex. Only reason to use array
is if it needs to be serializable, but an entity should never be serialized
directly.
But that wasn't your code...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
