Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/248#discussion_r19026297
--- Diff:
usage/rest-server/src/test/java/brooklyn/rest/util/json/BrooklynJacksonSerializerTest.java
---
@@ -77,7 +79,7 @@ public String toString() {
}
@Test
- public void
testCustomSerializerWithSerializableSillyManagementExample() throws
JsonGenerationException, JsonMappingException, IOException {
+ public void
testCustomSerializerWithSerializableSillyManagementExample() throws IOException
{
--- End diff --
Personal preference: all test methods to say `throws Exception`. We're not
testing the compiler, so might as well reduce amount of refactoring we may have
to do in the future. It's also more concise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
