Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/323#discussion_r20283387
--- Diff:
software/webapp/src/test/java/brooklyn/entity/webapp/tomcat/TomcatServerWebAppFixtureIntegrationTest.java
---
@@ -52,9 +57,24 @@
TestApplication tomcatApp = newTestApplication();
TomcatServer tomcat =
tomcatApp.createAndManageChild(EntitySpec.create(TomcatServer.class)
.configure(TomcatServer.HTTP_PORT,
PortRanges.fromString(DEFAULT_HTTP_PORT)));
-
+
+
+ File keystoreFile;
+ try {
+ keystoreFile = createTemporaryKeyStore("myname", "mypass");
+ keystoreFile.deleteOnExit();
+ } catch (Exception e) {
+ throw Exceptions.propagate(e);
+ }
+
+ TomcatServer httpsTomcat =
tomcatApp.createAndManageChild(EntitySpec.create(TomcatServer.class)
+ .configure(TomcatServer.HTTP_PORT,
PortRanges.fromString(DEFAULT_HTTP_PORT))
+ .configure(TomcatServer.ENABLED_PROTOCOLS,
ImmutableSet.of("https"))
+ .configure(TomcatServer.HTTPS_SSL_CONFIG,
+ new
HttpsSslConfig().keyAlias("myname").keystorePassword("mypass").keystoreUrl(keystoreFile.getAbsolutePath())));
+
return new JavaWebAppSoftwareProcess[][] {
- new JavaWebAppSoftwareProcess[] {tomcat}
+ new JavaWebAppSoftwareProcess[] { tomcat, httpsTomcat }
--- End diff --
should be
return new JavaWebAppSoftwareProcess[][] {
new JavaWebAppSoftwareProcess[] { tomcat },
new JavaWebAppSoftwareProcess[] { httpsTomcat }
(i'll fix)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
