Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/375#discussion_r21527868
--- Diff:
software/base/src/main/java/brooklyn/entity/basic/SoftwareProcess.java ---
@@ -253,6 +253,21 @@ private ChildStartableMode(boolean isDisabled, boolean
isBackground, boolean isL
public enum RestartMachineMode { TRUE, FALSE, AUTO }
}
+
+ public static class StopSoftwareParameters {
+ @Beta /** @since 0.7.0 semantics of parameters to restart being
explored */
+ public static final ConfigKey<Object> STOP_MACHINE =
ConfigKeys.newConfigKey(Object.class, "stopMachine",
+ "Whether to stop the machine provisioned for this entity:
'true', or 'false' are supported, "
+ + "with the default being 'true'",
+ StopMachineMode.TRUE.toString().toLowerCase());
+
+ // we supply a typed variant for retrieval; we want the untyped
(above) to use lower case as the default in the GUI
+ // (very hard if using enum, since enum takes the name, and
RendererHints do not apply to parameters)
+ @Beta /** @since 0.7.0 semantics of parameters to restart being
explored */
+ public static final ConfigKey<StopMachineMode> STOP_MACHINE_TYPED
= ConfigKeys.newConfigKey(StopMachineMode.class, "stopMachine");
+
+ public enum StopMachineMode { TRUE, FALSE }
--- End diff --
I suspect the `enum` is overkill for just a true/false (rather than us
using `Boolean`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
