[
https://issues.apache.org/jira/browse/BROOKLYN-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239590#comment-14239590
]
ASF GitHub Bot commented on BROOKLYN-72:
----------------------------------------
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/381
BROOKLYN-72: Fix deletion of OSGi cache dir
- Previously stopping Brooklyn almost always resulted in an
`IllegalArgumentException` at `log.info`, caused by a concurrent modification
when trying to delete the dir.
- Now will catch that to log.debug, and will also retry for one second.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn
fix/exception-logged-on-stop-for-osgi-dir-deletion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/381.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #381
----
commit 4c1727d59f8d6aec3ed8300c3f4701697b33fa52
Author: Aled Sage <[email protected]>
Date: 2014-12-09T16:12:20Z
BROOKLYN-72: Fix deletion of OSGi cache dir
- Previously stopping Brooklyn almost always resulted in an
IllegalArgumentException at log.info, caused by a concurrent
modification when trying to delete the dir.
- Now will catch that to log.debug, and will also retry for one second.
----
> Exception when stopping Brooklyn
> --------------------------------
>
> Key: BROOKLYN-72
> URL: https://issues.apache.org/jira/browse/BROOKLYN-72
> Project: Brooklyn
> Issue Type: Bug
> Reporter: Sam Corbett
>
> Brooklyn throws an unhandled IllegalArgumentException when cleaning up its
> OSGi cache directory.
> {code}
> $ brooklyn launch
> _ _ _
> | |__ _ __ ___ ___ | | _| |_ _ _ __ (R)
> | '_ \| '__/ _ \ / _ \| |/ / | | | | '_ \
> | |_) | | | (_) | (_) | <| | |_| | | | |
> |_.__/|_| \___/ \___/|_|\_\_|\__, |_| |_|
> |___/ 0.7.0-SNAPSHOT
> 2014-10-01 10:25:13,583 INFO Persistence disabled
> 2014-10-01 10:25:13,587 INFO High availability disabled
> 2014-10-01 10:25:16,701 INFO Started Brooklyn console at
> http://127.0.0.1:8081/, running classpath://brooklyn.war
> 2014-10-01 10:25:16,701 INFO Launched Brooklyn; will now block until
> shutdown issued. Shutdown via GUI or API or process interrupt.
> 2014-10-01 10:25:20,139 INFO Web console using security provider
> brooklyn.rest.security.provider.ExplicitUsersSecurityProvider
> 2014-10-01 10:25:20,142 INFO Web console allowing users: [sam]
> ^C2014-10-01 10:25:42,975 INFO terminateOnShutdown of
> LocalManagementContext[Zzdtwojs-jZZBPTEq] returned error (continuing):
> java.lang.IllegalArgumentException: /tmp/brooklyn-osgi-cache-fqEa/bundle18
> does not exist
> java.lang.IllegalArgumentException: /tmp/brooklyn-osgi-cache-fqEa/bundle18
> does not exist
> at
> org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1637)
> ~[commons-io-2.4.jar:2.4]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
