Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/395#discussion_r21840124
--- Diff:
software/network/src/main/java/brooklyn/entity/network/bind/BindDnsServerImpl.java
---
@@ -81,12 +80,11 @@
private static final CharMatcher DOMAIN_NAME_MATCHER =
DOMAIN_NAME_FIRST_CHAR_MATCHER
.or(CharMatcher.is('-'));
-
private class HostnameTransformer implements Function<Entity, String> {
@Override
public String apply(Entity input) {
String hostname =
input.getAttribute(getConfig(HOSTNAME_SENSOR));
- hostname =
DOMAIN_NAME_FIRST_CHAR_MATCHER.negate().trimFrom(hostname);
+ hostname =
DOMAIN_NAME_FIRST_CHAR_MATCHER.negate().trimLeadingFrom(hostname);
--- End diff --
OK, I misread the RFC, I think - you're right, it's ending with as well. My
bad, will close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
