Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/465#discussion_r23520391
--- Diff: core/src/main/java/brooklyn/util/crypto/FluentKeySigner.java ---
@@ -42,7 +44,9 @@
* X509v3CertificateBuilder drags in an add'l dependency (bcmail) and is
harder to use. */
@SuppressWarnings("deprecation")
public class FluentKeySigner {
-
+
+ static { Security.addProvider(new BouncyCastleProvider()); }
--- End diff --
I share the concern but I don't like the idea of mandating a specific entry
point as it would mean we can't easily run test classes on their own.
Maybe the thing to do is have a `BrooklynInitialization` class with statics
`initBouncyCastle()` and `initAll()` which we can invoke as and where needed?
Start-sequence-wise it wouldn't be any difference but at least the startup
logic would be in one place for reference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
