Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/503#discussion_r24244870
  
    --- Diff: 
software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java
 ---
    @@ -44,6 +45,13 @@
     public class RabbitSshDriver extends AbstractSoftwareProcessSshDriver 
implements RabbitDriver {
     
         private static final Logger log = 
LoggerFactory.getLogger(RabbitSshDriver.class);
    +
    +    // See http://fedoraproject.org/wiki/EPEL/FAQ#howtouse
    +    private static final Map<String, String> 
CENTOS_VERSION_TO_EPEL_VERSION = ImmutableMap.of(
    --- End diff --
    
    It would make sense to do this somewhere generic (e.g. `BashCommands`) as 
EPEL is not specific to Rabbit or even to Erlang. However, I'm ok with merging 
it here and then it being moved.
    
    I don't like just "waiting for the second usage" before refactoring, 
because downstream projects may want to use that - those projects should 
ideally be written without having to change core.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to