Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/565#discussion_r26974221
  
    --- Diff: 
software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNode.java ---
    @@ -142,6 +140,27 @@
         MethodEffector<Void> LEAVE_RIAK_CLUSTER = new 
MethodEffector<Void>(RiakNode.class, "leaveCluster");
         MethodEffector<Void> COMMIT_RIAK_CLUSTER = new 
MethodEffector<Void>(RiakNode.class, "commitCluster");
     
    +    AttributeSensor<String> NODE_GET_FSM_TIME_MEAN = 
Sensors.newStringSensor("node_get_fsm_time_mean", "Time between reception of 
client read request and subsequent response to client");
    --- End diff --
    
    Sensor names should be of the form `riak.node.fsm_time.mean` and should 
indicate in the description what the units are (milliseconds, perhaps?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to