Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30615966
--- Diff:
core/src/main/java/brooklyn/event/feed/windows/WindowsPerformanceCounterFeed.java
---
@@ -98,10 +104,11 @@
// This pattern matches CSV line(s) with the date in the first field,
and at least one further field.
protected static final Pattern lineWithPerfData =
Pattern.compile("^\"[\\d:/\\-. ]+\",\".*\"$", Pattern.MULTILINE);
private static final Joiner JOINER_ON_SPACE = Joiner.on(' ');
+ private static final Joiner JOINER_ON_COMMA = Joiner.on(',');
@SuppressWarnings("serial")
- public static final
ConfigKey<Set<WindowsPerformanceCounterPollConfig<?>>> POLLS =
ConfigKeys.newConfigKey(
- new TypeToken<Set<WindowsPerformanceCounterPollConfig<?>>>()
{},
+ public static final
ConfigKey<List<WindowsPerformanceCounterPollConfig<?>>> POLLS =
ConfigKeys.newConfigKey(
--- End diff --
Could/should we use Collection rather than List?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
