Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30687242
--- Diff:
locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -836,6 +910,52 @@ protected JcloudsSshMachineLocation
obtainOnce(ConfigBag setup) throws NoMachine
}
}
+ private void waitForWinRmAvailable(final NodeMetadata node, final
LoginCredentials expectedCredentials, ConfigBag setup) {
+ // TODO: Reduce / remove duplication between this and
waitForReachable
--- End diff --
Agree feels like a fair amount of duplication between this and
`waitForReachable`. Worth considering if can have a common impl, e.g. passing
in the checker, and the config key for wait time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---