Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/700#discussion_r32869026
--- Diff:
core/src/test/java/brooklyn/location/geo/HostGeoLookupIntegrationTest.java ---
@@ -34,6 +35,7 @@
public static final Logger log =
LoggerFactory.getLogger(HostGeoLookupIntegrationTest.class);
+ // Needs fast network connectivity to figure out the external IP. If
response not returned in 2s fails.
--- End diff --
Can't wait longer/differentiate the result here. It's designed to avoid
long blocks on purpose and fail gracefully.
We are already testing all implementations separately so it's worth
investigating if we can use stubs here to test the higher level logic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
