Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/763#discussion_r35313419
--- Diff:
software/base/src/main/java/brooklyn/entity/software/MachineLifecycleEffectorTasks.java
---
@@ -550,6 +575,27 @@ public void stop() {
* If no errors were encountered call {@link #postStopCustom()} at the
end.
*/
public void stop(ConfigBag parameters) {
+ doStop(parameters, new Callable<StopMachineDetails<Integer>>() {
--- End diff --
Now that `MachineLifecycleEffectorTasks` is configurable it could end up
being persisted. Don't introduce new anonymous classes even if no references to
them are kept, so that existing anonymous classes keep their indexes.
From what I see the anonymous classes are task bodies, so they are not
supposed to get persisted, but better be safe than sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
