Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/758#issuecomment-126488872
We **do** need `LICENSE`/`NOTICE`/`DISCLAIMER` for tests, as the test
artifacts are released by the project and published to Maven. This PR causes
these files to be missing from the test artifact, against Apache release policy.
Because the "main" parts of these two projects require custom LICENSE files
to account for bundled dependencies, the module's pom.xml disables
maven-remote-resources-plugin to stop it copying the boilerplate files, and
instead we supply our own files. However we're not able to disable the plugin
for "main" and enable it for "test" - we have to disable it for both -
therefore we also need to add `LICENSE`/`NOTICE`/`DISCLAIMER` for "test", even
though in this case it's just the unmodified Apache version of these files.
For the remaining projects, they do not have
`LICENSE`/`NOTICE`/`DISCLAIMER` in the source code, but
maven-remote-resources-plugin automatically installs those files into artifacts
(main and test) so they do not appear in the source folders.
See commit 430fb33 to see how this change was made.
(Apologies it's taken so long to review this.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
