GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/790

    Performance improvements and other things!

    An eclectic mix of things (which could have been split into multiple PRs, 
but if you're happy to review it in one PR then that's easier for me). See 
individual commits for details (copy-pasted below for your convenience, because 
I find it annoying to click through to each commit to see the details of all 
commits in the PR in github!).
    
    commit e1a06b18c893ad04019d406e8411d7aa1d029b6d
    Author: Aled Sage <[email protected]>
    Date:   Tue Aug 4 23:29:43 2015 +0100
    
        Adds CatalogYamlAppTest.testAddCatalogItemWithCircularReference
        
        A work-in-progress test, demonstrating a StackOverflowError.
    
    commit 651afa11a5f488ae8d8467bc051925b8370e5a59
    Author: Aled Sage <[email protected]>
    Date:   Tue Aug 4 23:23:58 2015 +0100
    
        Creates ApplicationsYamlTest
        
        Moves tests about app-wrapping from EntitiesYamlTest to
        ApplicationsYamlTest.
    
    commit 78d0aa2fa17a7957fc7e930f3a2998bd1072ebfb
    Author: Aled Sage <[email protected]>
    Date:   Tue Aug 4 23:23:02 2015 +0100
    
        Adds GeoscalingDnsService.SSL_TRUST_ALL
    
    commit fed5b8004f63fb8139a464c12fb07c6ebab1cabe
    Author: Aled Sage <[email protected]>
    Date:   Tue Aug 4 23:21:05 2015 +0100
    
        Fix SameServerEntity: up when all members up
    
    commit 33f39cdd2723e38b0d8274ca5697b72e7c0b6dbc
    Author: Aled Sage <[email protected]>
    Date:   Tue Aug 4 23:18:43 2015 +0100
    
        Tests for defaultDisplayName
    
    commit fecadef01f74f600dd3d4a8301bbf8637f8a82bc
    Author: Aled Sage <[email protected]>
    Date:   Tue Aug 4 23:17:43 2015 +0100
    
        Fix EntityManagementUtils.hasNoNameOrCustomKeysOrRoot
    
    commit 071a9232e864087c0be394cb813636b8e89b7d94
    Author: Aled Sage <[email protected]>
    Date:   Wed May 27 11:47:19 2015 +0100
    
        Adds sensor-notifications for GROUP_ADDED/REMOVED
    
    commit 22175cb4c30e7b92c2da16b304f700d215684e2c
    Author: Aled Sage <[email protected]>
    Date:   Tue Aug 4 21:47:12 2015 +0100
    
        Adds RecordingSensorEventListener (in src/test/java)
        
        Deletes the other multiple versions.
    
    commit 02e71ca4f48bdf4a80dda1aa870a3704cadddb66
    Author: Aled Sage <[email protected]>
    Date:   Mon May 25 22:25:30 2015 +0100
    
        Adds ControlledDynamicWebAppCluster.LOAD_BALANCED_GROUP
    
    commit 97fb0b02c75e7ad4079f65c093a7fc13e5bbe2ec
    Author: Aled Sage <[email protected]>
    Date:   Fri May 1 20:18:06 2015 +0100
    
        Fix subnetHostname (in JcloudsLocation’s private hostname)
    
    commit 8b473e576c10c419f6e65854b7287b4a061b47c9
    Author: Aled Sage <[email protected]>
    Date:   Fri May 1 20:17:04 2015 +0100
    
        Tidy Machines.java logging
    
    commit 37459b5f1e4558e8688415168668e812cd7dac21
    Author: Aled Sage <[email protected]>
    Date:   Thu Apr 23 21:21:18 2015 +0100
    
        Adds SoftwareProcess.SERVICE_NOT_UP_DIAGNOSTICS
        
        In SoftwareProcess, only do expensive checks (e.g. process-running)
        if serviceUp is false.
    
    commit acf3dd72cec01e8d74f8d83ea3ee7c3059d4eef9
    Author: Aled Sage <[email protected]>
    Date:   Sat Apr 18 14:40:33 2015 +0100
    
        Adds SoftwareProcess.RETRIEVE_USAGE_METRICS
        
        - RETRIEVE_USAGE_METRICS defaults to true
        - Setting RETRIEVE_USAGE_METRICS to false will disable the automatic
          retrieval of performance/usage metrics in some entity types.
        - Adds FeedConfig.enabled as an easy way to programmatically
          prevent a feed from being enabled (which can be easier to program
          against than guarding its creation with an if statement).
        - Adds TomcatServerDisableRetrieveUsageMetricsIntegrationTest
    
    commit c0c31e8c006c01b26f138124b56d5d4e7cefaf07
    Author: Aled Sage <[email protected]>
    Date:   Sat Apr 18 14:38:50 2015 +0100
    
        Adds TypeCoercions.function(Class)
    
    commit 3120987974bde20a85d780dfbe773d9bed6aa748
    Author: Aled Sage <[email protected]>
    Date:   Sat Apr 18 13:01:36 2015 +0100
    
        Entities suppress duplicates in feeds
    
    commit f20244bd51ffdba9f246a4afe317f1556322374e
    Author: Aled Sage <[email protected]>
    Date:   Sat Apr 18 12:50:48 2015 +0100
    
        Support suppressDuplicates for attributes in feeds
    
    commit 7d20c6a00836e2ec6a69367e3f680d6be0cfccc9
    Author: Aled Sage <[email protected]>
    Date:   Sat Apr 18 12:44:35 2015 +0100
    
        HttpValueFunctions: not anonymous inner classes
        
        - HttpValueFunctions uses static classes rather than anonymous inner
          classes
          (because they are extremely brittle in persisted state)
        - Adds containsHeader(), used by nginx
        - Nginx uses static classes, rather than anonymous inner classes
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn 
fix/performance-improvements-rebased-20150804

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/790.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #790
    
----
commit 7d20c6a00836e2ec6a69367e3f680d6be0cfccc9
Author: Aled Sage <[email protected]>
Date:   2015-04-18T11:44:35Z

    HttpValueFunctions: not anonymous inner classes
    
    - HttpValueFunctions uses static classes rather than anonymous inner
      classes
      (because they are extremely brittle in persisted state)
    - Adds containsHeader(), used by nginx
    - Nginx uses static classes, rather than anonymous inner classes

commit f20244bd51ffdba9f246a4afe317f1556322374e
Author: Aled Sage <[email protected]>
Date:   2015-04-18T11:50:48Z

    Support suppressDuplicates for attributes in feeds

commit 3120987974bde20a85d780dfbe773d9bed6aa748
Author: Aled Sage <[email protected]>
Date:   2015-04-18T12:01:36Z

    Entities suppress duplicates in feeds

commit c0c31e8c006c01b26f138124b56d5d4e7cefaf07
Author: Aled Sage <[email protected]>
Date:   2015-04-18T13:38:50Z

    Adds TypeCoercions.function(Class)

commit acf3dd72cec01e8d74f8d83ea3ee7c3059d4eef9
Author: Aled Sage <[email protected]>
Date:   2015-04-18T13:40:33Z

    Adds SoftwareProcess.RETRIEVE_USAGE_METRICS
    
    - RETRIEVE_USAGE_METRICS defaults to true
    - Setting RETRIEVE_USAGE_METRICS to false will disable the automatic
      retrieval of performance/usage metrics in some entity types.
    - Adds FeedConfig.enabled as an easy way to programmatically
      prevent a feed from being enabled (which can be easier to program
      against than guarding its creation with an if statement).
    - Adds TomcatServerDisableRetrieveUsageMetricsIntegrationTest

commit 37459b5f1e4558e8688415168668e812cd7dac21
Author: Aled Sage <[email protected]>
Date:   2015-04-23T20:21:18Z

    Adds SoftwareProcess.SERVICE_NOT_UP_DIAGNOSTICS
    
    In SoftwareProcess, only do expensive checks (e.g. process-running)
    if serviceUp is false.

commit 8b473e576c10c419f6e65854b7287b4a061b47c9
Author: Aled Sage <[email protected]>
Date:   2015-05-01T19:17:04Z

    Tidy Machines.java logging

commit 97fb0b02c75e7ad4079f65c093a7fc13e5bbe2ec
Author: Aled Sage <[email protected]>
Date:   2015-05-01T19:18:06Z

    Fix subnetHostname (in JcloudsLocation’s private hostname)

commit 02e71ca4f48bdf4a80dda1aa870a3704cadddb66
Author: Aled Sage <[email protected]>
Date:   2015-05-25T21:25:30Z

    Adds ControlledDynamicWebAppCluster.LOAD_BALANCED_GROUP

commit 071a9232e864087c0be394cb813636b8e89b7d94
Author: Aled Sage <[email protected]>
Date:   2015-05-27T10:47:19Z

    Adds sensor-notifications for GROUP_ADDED/REMOVED

commit 22175cb4c30e7b92c2da16b304f700d215684e2c
Author: Aled Sage <[email protected]>
Date:   2015-08-04T20:47:12Z

    Adds RecordingSensorEventListener (in src/test/java)
    
    Deletes the other multiple versions.

commit fecadef01f74f600dd3d4a8301bbf8637f8a82bc
Author: Aled Sage <[email protected]>
Date:   2015-08-04T22:17:43Z

    Fix EntityManagementUtils.hasNoNameOrCustomKeysOrRoot

commit 33f39cdd2723e38b0d8274ca5697b72e7c0b6dbc
Author: Aled Sage <[email protected]>
Date:   2015-08-04T22:18:43Z

    Tests for defaultDisplayName

commit fed5b8004f63fb8139a464c12fb07c6ebab1cabe
Author: Aled Sage <[email protected]>
Date:   2015-08-04T22:21:05Z

    Fix SameServerEntity: up when all members up

commit 78d0aa2fa17a7957fc7e930f3a2998bd1072ebfb
Author: Aled Sage <[email protected]>
Date:   2015-08-04T22:23:02Z

    Adds GeoscalingDnsService.SSL_TRUST_ALL

commit 651afa11a5f488ae8d8467bc051925b8370e5a59
Author: Aled Sage <[email protected]>
Date:   2015-08-04T22:23:58Z

    Creates ApplicationsYamlTest
    
    Moves tests about app-wrapping from EntitiesYamlTest to
    ApplicationsYamlTest.

commit e1a06b18c893ad04019d406e8411d7aa1d029b6d
Author: Aled Sage <[email protected]>
Date:   2015-08-04T22:29:43Z

    Adds CatalogYamlAppTest.testAddCatalogItemWithCircularReference
    
    A work-in-progress test, demonstrating a StackOverflowError.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to