Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/790#discussion_r36395223
--- Diff:
sandbox/extra/src/main/java/brooklyn/entity/database/postgresql/PostgreSqlNodeSaltImpl.java
---
@@ -174,4 +175,8 @@ public String executeScript(String commands) {
ConfigBag.newInstance().configure(ExecuteScriptEffectorBody.SCRIPT,
commands).getAllConfig()).getUnchecked();
}
+ @Override
+ public void populateServiceNotUpDiagnostics() {
+ // FIXME no-op currently; should check ssh'able etc
+ }
--- End diff --
`FIXME` is a bit strong. This surely applies to many other entities, so
highlighting this case seems a bit random ;o)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
