Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/790#issuecomment-130061843
Thanks @alasdairhodge @sjcorbett for the review - incorporated almost all
your comments. The things that remain are:
* The `if (!config.isEnabled()) continue;` check in the feeds.
* Should we have a global enabled option on the feed itself to cater for
these cases where all pollAttributes are gated on the same condition?
* dynamically update SoftwareProcess.RETRIEVE_USAGE_METRICS on an entity
and have its feeds enabled or disabled automatically.
I think our feeds need to be revisited. They were written to be
(relatively) simple - they assume that the configuration is static. To cope
with dynamic changes, we'll need to ensure that poll period etc will
automatically reconfigure on-the-fly as things are enabled/disabled or
added/removed.
Let's not address these in this PR. It warrants discussion on the mailing
list.
Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
