Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#discussion_r37149217
--- Diff: software/database/pom.xml ---
@@ -107,18 +107,10 @@
<artifactId>groovy-all</artifactId>
</dependency>
<dependency>
- <groupId>com.beust</groupId>
- <artifactId>jcommander</artifactId>
- </dependency>
- <dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
<dependency>
- <groupId>com.google.code.findbugs</groupId>
- <artifactId>jsr305</artifactId>
--- End diff --
Why remove this? It's used for `@Nullable`, which is used in
`DatastoreMixins` etc. It's also a transitive dependency from brooklyn-api etc.
I believe the convention that @rdowner implemented was that if a package
directly uses a class then it includes the dependency as an explicit dependency.
I can't remember whether that is still the convention - I vaguely remember
a discussion and some disagreement about it previously. Personally, I have no
strong feelings except that we are consistent.
@rdowner can you comment please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
