Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/846#issuecomment-132621121
Have addressed, and will push. Agree with all comments, except:
* generics, I applied this but it doesn't help much as we abandon the
generics in the impl; the Transformer interface is not marked `@Beta` as a
class so we can experiement; also, we might want to support ZIPs and other
items in future
* use of `CampCatalogUtils` - no strong feelings, this is how @neykov did
it originally. it can move back and forth. (this project should not really be
part of the public API. when we do OSGi we can make it `export-package: none`
due to `ServiceLoader`!)
pushing and merging now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
