Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/854#issuecomment-132816079
looks great. merging. to your other questions:
* `org.apache.brooklyn.camp.brooklyn.api.HasBrooklynManagementContext` -
let's move this to be alongside `ManagementContextInjectable`
* underscore - this is becoming more common with python ascending but no
strong feelings
* `SshCommandEffector` move to `o.a.b.effector.core.ssh`
* enrichers to `brooklyn-policy` - i think not
the others i think are less important and/or less clear, and for now we
should do nothing with them. when we osgify things hopefully many of the
packages can avoid being exported, and these we can move to `internal`
sub-packages. (and if any `internal` ones are used, we fix those.) i am less
concerned with doing that later on as it will not be very disruptive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
