Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/850#discussion_r37578140
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/CatalogPredicates.java ---
@@ -39,21 +39,65 @@
public class CatalogPredicates {
public static <T,SpecT> Predicate<CatalogItem<T,SpecT>>
isCatalogItemType(final CatalogItemType ciType) {
- return new Predicate<CatalogItem<T,SpecT>>() {
+ // TODO PERSISTENCE WORKAROUND kept anonymous function in case
referenced in persisted state
+ new Predicate<CatalogItem<T,SpecT>>() {
@Override
public boolean apply(@Nullable CatalogItem<T,SpecT> item) {
return (item != null) && item.getCatalogItemType()==ciType;
}
};
+ return new CatalogItemTypeEqualTo<T, SpecT>(ciType);
+ }
+
+ private static class CatalogItemTypeEqualTo<T,SpecT> implements
Predicate<CatalogItem<T,SpecT>> {
+ private final CatalogItemType ciType;
+
+ public CatalogItemTypeEqualTo(final CatalogItemType ciType) {
+ this.ciType = ciType;
+ }
+ @Override
+ public boolean apply(@Nullable CatalogItem<T,SpecT> item) {
+ return (item != null) && item.getCatalogItemType()==ciType;
+ }
}
public static <T,SpecT> Predicate<CatalogItem<T,SpecT>>
deprecated(final boolean deprecated) {
- return new Predicate<CatalogItem<T,SpecT>>() {
+ // TODO PERSISTENCE WORKAROUND kept anonymous function in case
referenced in persisted state
--- End diff --
as above, `@since`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
