Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/860#issuecomment-133426655
Looks good - a nice improvement.
I don't see the value of using `attemptWithLoaders` vs passing the string
directly, but it's just a personal preference (don't like the syntax overhead
of anonymous classes).
Also the `OVERRIDE` test property is a bit smelly, but agree it's the best
we can do without introducing even more abstraction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
