Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/865#issuecomment-135043666
  
    A few comments:
    
    * If I have nothing in the catalog, it shows me YAML editor and it looks 
nice.  Surprising at first how lines are added but it's nice.  Cut and paste 
and other things work as expected.
    * If I then click on the "catalog" tab, with nothing there, i have option 
to write YAML blueprint.  I click that button and it returns me to the YAML 
tab, but a *new* editor is added.  This looks like a bug.
    * If I leave the wizard, go to the catalog and add some YAML (e.g. 
default.catalog.bom from CLI project), then open the add wizard, I have the 
catalog tab selected (good), but then when I go to the YAML editor I get the 
*old* YAML view.
    
    Of course we need RAT re-enabled.
    
    Code completion will require some REST API enhancements or better 
understanding of the model in the client.  I'd also like to see this as a 
separate main tab, rather than a wizard.  But we can leave these for a 
follow-on PR, as with the bug fixes before this paragraph resolved, this is a 
nice improvement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to